Skip to content

xHud#566

Merged
JoshSanch merged 1 commit intobfbbdecomp:mainfrom
stravant:xHud
May 22, 2025
Merged

xHud#566
JoshSanch merged 1 commit intobfbbdecomp:mainfrom
stravant:xHud

Conversation

@stravant
Copy link
Collaborator

  • The annoying one in here is for_each. It almost matches minus the handling for the variable size of the elements as a for (i < count) doStuff(array[i]) style loop, but stops matching well when I try to factor the variable element size in.

@github-actions
Copy link

🆗 ✅

+1544 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

No Regressions 🎉

Progress: 22

📈 main/SB/Core/x/xHud - .text +1352 bytes -> 86.12%
📈 main/SB/Core/x/xHud - .rodata +121 bytes -> 33.56%
📈 main/SB/Core/x/xHud - .text +71 bytes -> 92.52%
📈 main/SB/Core/x/xHud - .sdata2 +2 bytes -> 91.67%
📈 main/SB/Core/x/xHud - xhud::render_model(xModelInstance&, const xhud::render_context&) +276 bytes -> 85.19%
main/SB/Core/x/xHud - xhud::shake_motive_update(xhud::widget&, xhud::motive&, float) +148 bytes -> 100.00%
📈 main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::for_each<void (*)(xhud::widget&)>(unsigned char, unsigned int, void (*)(xhud::widget&)) +47 bytes -> 35.29%
📈 main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::for_each<xhud::@unnamed@xHud_cpp@::functor_update>(unsigned char, unsigned int, xhud::@unnamed@xHud_cpp@::functor_update) +31 bytes -> 24.24%
📈 main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::for_each<xhud::@unnamed@xHud_cpp@::functor_disable>(unsigned char, unsigned int, xhud::@unnamed@xHud_cpp@::functor_disable) +31 bytes -> 24.24%
main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::render_one_model(xModelInstance&, float, const basic_rect<float>&, const xVec3&, const xVec3&, const xMat4x3&) +116 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::widget::disable_all(bool) +108 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::widget::render_all() +108 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::widget::setup_all() +104 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::widget::update_all(float) +104 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::functor_disable::operator()(xhud::widget&) +92 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::functor_update::operator()(xhud::widget&) +92 bytes -> 100.00%
📈 main/SB/Core/x/xHud - xhud::delay_motive_update(xhud::widget&, xhud::motive&, float) +72 bytes -> 81.82%
main/SB/Core/x/xHud - xhud::motive::motive(const xhud::motive&) +68 bytes -> 100.00%
📈 main/SB/Core/x/xHud - xhud::widget::cb_dispatch(xBase*, xBase*, unsigned int, const float*, xBase*) +4 bytes -> 6.67%
main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::functor_disable::functor_disable(bool) +8 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::@unnamed@xHud_cpp@::functor_update::functor_update(float) +8 bytes -> 100.00%
main/SB/Core/x/xHud - xhud::widget::debug_render() +4 bytes -> 100.00%

Copy link
Collaborator

@JoshSanch JoshSanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@JoshSanch JoshSanch merged commit 8bb2c43 into bfbbdecomp:main May 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants